build: optionally install systemd service #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using a systemd based distro, it is useful to have the service file installed so that it properly integrates with the service manager. Certain distros are carrying around patches that accomplish this.
989e604 to
41ee397
Compare
|
FWIW, this was dropped in #338. |
|
It looks like that was more about the apparmor support than the systemd service? From a quick check I did not see a lot of issues about the systemd service that were distro specific, but I could be missing some issues. Given that many distros seem to be carrying this patch around, and that there have not been a lot of (any?) bug reports specific to those patches, I think this is still maintainer friendly. Since I actively use mako with systemd support I would also volunteer to triage systemd bugs, fwiw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of how systemd support is handled in
xdpw.I believe this is a genuinely useful feature, and that it does not interfere with non-systemd based distros/OSes in any meaningful way. Downstream distros have been carrying support for this for some time:
Probably others, too. These were just the first three I checked.