Fixes from review

emilk · lucasmerlin · Jul 16, 2025 · Jul 16, 2025 · Jul 23, 2025 · Jul 23, 2025
commit c857fb949162ca96d68ff5883a85ce6bb6f2d3cb
diff --git a/crates/egui/src/context.rs b/crates/egui/src/context.rs
@@ -1836,8 +1836,7 @@ impl Context {
 impl Context {
     /// Call the given callback at the start of each pass of each viewport.
     ///
-    /// This can be used for egui _plugins_.
-    /// See [`crate::debug_text`] for an example.
+    /// This is a convenience wrapper around [`Self::add_plugin`].
     pub fn on_begin_pass(&self, debug_name: &'static str, cb: plugin::ContextCallback) {
         self.with_plugin(|p: &mut crate::plugin::CallbackPlugin| {
             p.on_begin_plugins.push((debug_name, cb));
@@ -1846,8 +1845,7 @@ impl Context {
 
     /// Call the given callback at the end of each pass of each viewport.
     ///
-    /// This can be used for egui _plugins_.
-    /// See [`crate::debug_text`] for an example.
+    /// This is a convenience wrapper around [`Self::add_plugin`].
     pub fn on_end_pass(&self, debug_name: &'static str, cb: plugin::ContextCallback) {
         self.with_plugin(|p: &mut crate::plugin::CallbackPlugin| {
             p.on_end_plugins.push((debug_name, cb));

diff --git a/crates/egui/src/debug_text.rs b/crates/egui/src/debug_text.rs
@@ -53,15 +53,13 @@ pub struct DebugTextPlugin {
 }
 
 impl Plugin for DebugTextPlugin {
-    fn name(&self) -> &'static str {
+    fn debug_name(&self) -> &'static str {
         "DebugTextPlugin"
     }
 
     fn on_end_pass(&mut self, ctx: &Context) {
-        if !self.entries.is_empty() {
-            let entries = std::mem::take(&mut self.entries);
-            Self::paint_entries(ctx, entries);
-        }
+        let entries = std::mem::take(&mut self.entries);
+        Self::paint_entries(ctx, entries);
     }
 }
 

diff --git a/crates/egui/src/drag_and_drop.rs b/crates/egui/src/drag_and_drop.rs
@@ -25,7 +25,7 @@ pub struct DragAndDrop {
 }
 
 impl Plugin for DragAndDrop {
-    fn name(&self) -> &'static str {
+    fn debug_name(&self) -> &'static str {
         "DragAndDrop"
     }
 

diff --git a/crates/egui/src/id.rs b/crates/egui/src/id.rs
@@ -79,10 +79,6 @@ impl Id {
         self.0.get()
     }
 
-    pub fn from_value(value: u64) -> Self {
-        Self::from_hash(value)
-    }
-
     #[cfg(feature = "accesskit")]
     pub(crate) fn accesskit_id(&self) -> accesskit::NodeId {
         self.value().into()

diff --git a/crates/egui/src/plugin.rs b/crates/egui/src/plugin.rs
@@ -14,7 +14,7 @@ pub trait Plugin: Send + Sync + 'static {
     /// Plugin name.
     ///
     /// Used when profiling.
-    fn name(&self) -> &'static str;
+    fn debug_name(&self) -> &'static str;
 
     /// Called once, when the plugin is registered.
     ///
@@ -31,17 +31,17 @@ pub trait Plugin: Send + Sync + 'static {
     /// Can be used to show ui, e.g. a [`crate::Window`].
     fn on_end_pass(&mut self, ctx: &Context) {}
 
-    /// Called just before the output is passed to the backend.
-    ///
-    /// Useful to inspect or modify the output.
-    /// Since this is called outside a pass, don't show ui here.
-    fn output_hook(&mut self, output: &mut FullOutput) {}
-
     /// Called just before the input is processed.
     ///
     /// Useful to inspect or modify the input.
     /// Since this is called outside a pass, don't show ui here.
     fn input_hook(&mut self, input: &mut RawInput) {}
+
+    /// Called just before the output is passed to the backend.
+    ///
+    /// Useful to inspect or modify the output.
+    /// Since this is called outside a pass, don't show ui here.
+    fn output_hook(&mut self, output: &mut FullOutput) {}
 }
 
 pub(crate) struct PluginHandle {
@@ -140,7 +140,7 @@ impl PluginsOrdered {
     {
         for plugin in &self.0 {
             let mut plugin = plugin.lock();
-            profiling::scope!("plugin", plugin.dyn_plugin_mut().name());
+            profiling::scope!("plugin", plugin.dyn_plugin_mut().debug_name());
             f(plugin.dyn_plugin_mut());
         }
     }
@@ -213,7 +213,7 @@ pub(crate) struct CallbackPlugin {
 }
 
 impl Plugin for CallbackPlugin {
-    fn name(&self) -> &'static str {
+    fn debug_name(&self) -> &'static str {
         "CallbackPlugins"
     }
 

diff --git a/crates/egui/src/text_selection/label_text_selection.rs b/crates/egui/src/text_selection/label_text_selection.rs
@@ -124,7 +124,7 @@ impl Default for LabelSelectionState {
 }
 
 impl Plugin for LabelSelectionState {
-    fn name(&self) -> &'static str {
+    fn debug_name(&self) -> &'static str {
         "LabelSelectionState"
     }