feat(toolpath-desktop): inline browse view in New upload tabs#33
Merged
Conversation
Clicking a source tab (Claude Code, Pi.dev, Git, GitHub PR) on the New upload screen now shows the live browse view directly, replacing the prior description card and extra "Browse X →" click. Each Browse component gets an `embedded` prop that skips its outer `.page` padding, back button, and duplicated page header so it nests cleanly inside Home. Added idempotent `ClaudeEnsureProjects`, `PiEnsureProjects`, and `GithubEnsureTokenStatus` messages dispatched on mount — previously the project-stream / keychain probe rode on the `NavigateTo` handler, which never fired in the embedded flow.
dea3961 to
09ca3a4
Compare
|
🔍 Preview deployed: https://281be6d5.toolpath.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
embeddedprop that drops its outer.pagepadding, back button, and duplicated page header so it nests cleanly inside Home.ClaudeEnsureProjects,PiEnsureProjects, andGithubEnsureTokenStatusmessages dispatched on mount. Previously the streaming project load / keychain probe rode on theNavigateTohandler — which never fires for an embedded component, so the Claude tab came up empty after the refactor.Why
The old flow required two clicks (pick tab → click "Browse") and showed boilerplate copy in between. For a non-technical-user upload path, tabs should show the live data immediately.
Test plan
cargo tauri dev→ New upload, click Claude Code tab → session list populates from~/.claude/projects/without an extra click.Preview →is pressed.browse-*routes (if still reachable) render with their own header + back button (non-embedded default).Verification run:
bun run check→ 0 errors;bun run build→ succeeds.