feat(nodefs): mmap and msync #10669
Merged
feat(nodefs): mmap and msync #10669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Mar 10, 2020
src/library_nodefs.js
Outdated
| throw new FS.ErrnoError({{{ cDefine('ENODEV') }}}); | ||
| } | ||
| var ptr = _malloc(length); | ||
| NODEFS.stream_ops.read(stream, buffer, ptr + offset , length, position); |
There was a problem hiding this comment.
extra space before one of the ,s
| } | ||
| var ptr = _malloc(length); | ||
| NODEFS.stream_ops.read(stream, buffer, ptr + offset , length, position); | ||
|
|
There was a problem hiding this comment.
comparing to MEMFS, offset is not used there, but you add it here - is that a bug there, or here? If we aren't sure, an assertion that the offset is 0 might be good enough for now.
There was a problem hiding this comment.
not sure actually, so I've added the assertion as you suggest.
add implementation of mmap and msync for NODEFS
196e459 to
3188415
Compare
kripken
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add implementation of mmap and msync for NODEFS