socket: return EPROTONOSUPPORT on invalid protocol #16479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid socket protocol now fails with errno EPROTONOSUPPORT instead of crashing with an assertion error.
15 tasks
sbc100
reviewed
Mar 13, 2022
| if (protocol) { | ||
| assert(streaming == (protocol == {{{ cDefine('IPPROTO_TCP') }}})); // if SOCK_STREAM, must be tcp | ||
| if (streaming && protocol && protocol != {{{ cDefine('IPPROTO_TCP') }}}) { | ||
| throw new FS.ErrnoError({{{ cDefine('EPROTONOSUPPORT') }}}); // if SOCK_STREAM, must be tcp or 0. |
There was a problem hiding this comment.
In my experience it is very common to use socket(AF_INET, SOCK_STREAM, 0) to create a IPv4 TCP socket. I have rarely seen IPPROTO_TCP. It works fine on Linux, FreeBSD, macOS, and Windows.
There was a problem hiding this comment.
Ah yes. I see. From the man page:
Normally only a single protocol exists to support a particular socket type within a given
protocol family, in which case protocol can be specified as 0.
sbc100
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid socket protocol now fails with errno EPROTONOSUPPORT instead of
crashing with an assertion error.