Not allow to pass an empty actions to viewset.as_view() #2175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
Merge upstream
|
Also add unittest for viewset.as_view() |
tests/test_viewsets.py
Outdated
There was a problem hiding this comment.
METHOD is a confusing string to use here, as it could mean the request method. ACTION would be more descriptive.
lovelydinosaur
added a commit
that referenced
this pull request
Dec 3, 2014
Not allow to pass an empty actions to viewset.as_view()
|
Thanks! |
|
Not sure, but I was following the documentation about testing and got this exception
So, should the documentation be updated to add this actions argument? http://www.django-rest-framework.org/api-guide/testing/#forcing-authentication |
|
AccountDetail isn't a viewset so it doesn't have any use of the actions |
|
Ah yeah, of course, sometimes all the different kind of views are confusing ;) |
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Nov 14, 2017
This was referenced Dec 10, 2017
This was referenced Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate actions value when invoke as_view(), raise a TypeError if no actions was passed in.
Refs #2171