Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix GitHub Actions to run on 'master' branch #7926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

Fix GitHub Actions to run on 'master' branch #7926

merged 1 commit into from
Apr 16, 2021
+1 −1

Conversation

adamchainz
Copy link
Contributor

The config I copied in #7903 was from a repo with the new name 'main', so tests have not been running on master since.

@adamchainz
Fix GitHub Actions to run on 'master' branch
62b3ba3 
The config I copied in encode#7903 was from a repo with the new name 'main', so tests have not been running on master since.
@adamchainz
Copy link
Contributor Author

So this test failure is happening only on base and dist:

_____ TestNaiveDayLightSavingTimeTimeZoneDateTimeField.test_invalid_inputs _____
tests/test_fields.py:621: in test_invalid_inputs
    assert exc_info.value.detail == expected_failure, \
E   AssertionError: input value: '2017-03-12T02:30:00'
E   assert [ErrorDetail(...de='invalid')] == ['Invalid dat...a/New_York".']
E     At index 0 diff: ErrorDetail(string='Datetime has wrong format. Use one of these formats instead: YYYY-MM-DDThh:mm[:ss[.uuuuuu]][+HH:MM|-HH:MM|Z].', code='invalid') != 'Invalid datetime for the timezone "America/New_York".'
E     Use -v to get the full diff

I am not sure where this would have come from 🤔

@smithdc1
Copy link
Contributor

#7911 seems to be a fix for this?

@adamchainz
Copy link
Contributor Author

Well spotted, thanks @smithdc1 .

I will merge this now to check tests do run on master, then will review that PR.

@adamchainz adamchainz merged commit f628db3 into encode:master Apr 16, 2021
@adamchainz adamchainz deleted the fix-github-actions-master branch April 16, 2021 16:23
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@adamchainz @sigvef
Fix GitHub Actions to run on 'master' branch (encode#7926)
b3cfc1f 
The config I copied in encode#7903 was from a repo with the new name 'main', so tests have not been running on master since.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamchainz @smithdc1