Upgrade to tox 4 #8795
Merged
Upgrade to tox 4 #8795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
commented
Dec 8, 2022
| @@ -7,15 +7,6 @@ envlist = | |||
| {py311}-{django41,djangomain}, | |||
| base,dist,docs, | |||
|
|
|||
| [travis:env] | |||
There was a problem hiding this comment.
config for tox-travis, I missed removing it in #7903
adamchainz
commented
Dec 8, 2022
Comment on lines
+3
to
+10
| {py36,py37,py38,py39}-django30 | ||
| {py36,py37,py38,py39}-django31 | ||
| {py36,py37,py38,py39,py310}-django32 | ||
| {py38,py39,py310}-{django40,django41,djangomain} | ||
| {py311}-{django41,djangomain} | ||
| base | ||
| dist | ||
| docs |
There was a problem hiding this comment.
this change is not necessary but it will reduce diff noise going forwards
| @@ -39,7 +32,7 @@ deps = | |||
| -rrequirements/requirements-testing.txt | |||
|
|
|||
| [testenv:dist] | |||
| commands = ./runtests.py --no-pkgroot --staticfiles {posargs} | |||
| commands = python -W error::DeprecationWarning -W error::PendingDeprecationWarning runtests.py --no-pkgroot --staticfiles {posargs} | |||
There was a problem hiding this comment.
tox no longer allows ./runtests.py to work, failing with:
dist: failed with ./runtests.py (resolves to ./runtests.py) is not allowed, use allowlist_externals to allow it
but we can use python runtests.py instead
I also added the warning flags as added to the main [testenv] in #7900
carltongibson
approved these changes
Dec 8, 2022
adamchainz
commented
Dec 8, 2022
| tox -e base,dist,docs | ||
| tox -e dist --installpkg ./dist/djangorestframework-*.whl |
There was a problem hiding this comment.
I think this run is no longer required because tox now uses isolated builds by default.
We need to remove it because --installpkg seems to be incompatible with deps, or some other option we're using, leading to:
ROOT: HandledError| .pkg_external is already defined as a virtualenv-cmd-builder, cannot be virtualenv-pep-517 too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #458 for this repo.
tox 4 has just been released: https://fosstodon.org/@gaborbernat/109473528072009278
tox-py no longer works with it, but that’s okay since the new
-ffactor option fills the need to run Python 3.X tests in the Python 3.X CI run. I documented this pattern in the package install instructions: https://github.com/adamchainz/tox-py/#installation . Plus, I’ve already changed all the projects I maintain to use it, for example: adamchainz/django-htmx#296tox 4 only supports Python 3.7+. I’ve added a temporary fork on Python version to retain running with old tox and tox-py on Python 3.6. I think we should drop Python 3.6 in a follow-up PR since it’s been EOL for a while now.