-
Notifications
You must be signed in to change notification settings - Fork 122
json_encode() needs recursive algorithm
#2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… files Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
…ode() the right way Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
Signed-off-by: Saif Kandil <[email protected]>
|
Is this still needed for #2350? |
This is needed in general, currently, the Steamworks extension doesn't have recursive DS maps, they are all in one level, so need for it for now. Also, as I said we need this in general for ENIGMA. |
|
Ok, is it not done then? Why is it still in draft? Does steamworks pr at least compile without this? Need more context so I can tell if I should merge this. |
|
@RobertBColton We talked about this before:
My PR works fine without this, yeah and actually there is no crash even if we did resolve this. This is because instead of printing he nested JSON, we print its id, which is not correct. This is where this PR comes in and solves this issue but after discussing this with you, it seems like there must be compiler changes to resolve it, so it's a draft and I don't have any idea when this will be ready. |
|
Ok, that's fine, thanks! |
We need to create DS accessors for detecting the type of DS, is it a
ds_mapords_list.Related issues #2354
Related PRs #2353, #2357, #2352, #2355
Fixed this issue the right way #2339