Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@k0T0z
Copy link
Contributor

@k0T0z k0T0z commented Aug 19, 2023

We need to create DS accessors for detecting the type of DS, is it a ds_map or ds_list.

Related issues #2354
Related PRs #2353, #2357, #2352, #2355

Fixed this issue the right way #2339

@RobertBColton
Copy link
Contributor

Is this still needed for #2350?

@k0T0z
Copy link
Contributor Author

k0T0z commented Sep 30, 2023

Is this still needed for #2350?

This is needed in general, currently, the Steamworks extension doesn't have recursive DS maps, they are all in one level, so need for it for now.

Also, as I said we need this in general for ENIGMA.

@RobertBColton
Copy link
Contributor

Ok, is it not done then? Why is it still in draft? Does steamworks pr at least compile without this?

Need more context so I can tell if I should merge this.

@k0T0z
Copy link
Contributor Author

k0T0z commented Oct 1, 2023

@RobertBColton We talked about this before:
R0bert — 19/08/2023 19:19

this is where data structure accessors come in
GML has a special syntax for it but we never added it
Josh doesn't know how to support them

My PR works fine without this, yeah and actually there is no crash even if we did resolve this. This is because instead of printing he nested JSON, we print its id, which is not correct. This is where this PR comes in and solves this issue but after discussing this with you, it seems like there must be compiler changes to resolve it, so it's a draft and I don't have any idea when this will be ready.

@RobertBColton
Copy link
Contributor

Ok, that's fine, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants