#2371 fix:Steamworks logo is now showing #2372
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Daksh-10 Okay I will test your changes asap. I don't think we will need that |
Closed
Contributor
|
@Daksh-10 Thank you for your contribution. I tested your PR and it's working but it needs some modifications before merging. |
k0T0z
suggested changes
Dec 17, 2023
start.sh
Outdated
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
Let's remove this file as it's not related.
Contributor
There was a problem hiding this comment.
Let's also roll back this change as it affects nothing.
Author
|
Ok I will change it, tq for reviewing it |
Author
|
@k0T0z I reverted back the changes |
Contributor
|
@Daksh-10 That's great, I think it's now ready for merging but let me check if it needs something else and then approve it. Great work 👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #2371
On going through the code, I found out in the yaml file of steamworks, the icon tag didn't had the correct file name, I changed it, also the svg wasnot working, I clearly didn't know why so I rather did put a steamwork.png image, also I added a start.sh file, so ubuntu and debian users don't need to install it separately.