Fix delayed background de-duplication and deprecate deprecate-staleRefreshTimeout
#134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this syncrounous calls or cases with staleRefreshTimeout > 0 would queue up a lot of work and thereby behave different to the default de-duplication behavior this change queues up background refreshes imediately and then delays the potentially bigger work in `getFreshValue` fix #132
kentcdodds
approved these changes
Apr 3, 2025
|
🎉 This PR is included in version 5.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background refreshes are now de-duplicated as expected
By moving the timeout/sleep just before the potential heavy work happens in
getFreshValuedeprecate-staleRefreshTimeoutis deprecated as an option in favor of manually handling it likeAs discussed in Only one pending refresh on staleRefreshTimeout #132, this option was only added to stay 100% backwards compatible with the original implementation and now seems to be rather misleading.