Fix global ordering and wire sortDirection in boxes byAddress/byErgoT…#285
Open
Ergologica wants to merge 1 commit into
Open
Fix global ordering and wire sortDirection in boxes byAddress/byErgoT…#285Ergologica wants to merge 1 commit into
Ergologica wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose spending proof context extension in v1 transaction inputs
Closes #264
The problem
The v1 Explorer API does not return the spending proof context extension of transaction inputs, while the node API does (
spendingProof.extension). Example from #264:/api/v1/transactions/{id}returns inputs withspendingProof(proof bytes) only, with no way to see the context extension variables the input was spent with.The data is already indexed: the
node_inputstable has anextension JSON NOT NULLcolumn and theInputDB model carries it (extension: Json) — it was simply never exposed in the API model.The fix
v1/models/InputInfonow includes anextension: Jsonfield (placed next tospendingProof, consistent with the node'sspendingProof: { proofBytes, extension }shape), populated fromFullInput.input.extension, with the corresponding tapir schema description. All v1 endpoints returningInputInfo(transactions by id, by address, etc.) now include the extension; the OpenAPI docs are derived from the schema, so they update automatically.Non-breaking: the change only adds a field to the response payload.