Discovery zero refresh timer#8661
Merged
Merged
Conversation
battlmonstr
added a commit
that referenced
this pull request
Jan 10, 2024
mh0lt
pushed a commit
that referenced
this pull request
Jan 11, 2024
battlmonstr
added a commit
that referenced
this pull request
Jan 11, 2024
yperbasis
added a commit
that referenced
this pull request
Jan 11, 2024
wmitsuda
added a commit
that referenced
this pull request
Jan 19, 2024
commit 0c7300e Author: Willian Mitsuda <[email protected]> Date: Fri Jan 12 20:05:43 2024 -0300 Squashed work from ots2-alpha4 commit c9216ce Author: battlmonstr <[email protected]> Date: Thu Jan 11 17:13:46 2024 +0100 p2p/discv4: revert gotreply handler change from #8661 (#9119) (#9195) (#9210) Co-authored-by: yperbasis <[email protected]> commit d079008 Author: Andrew Ashikhmin <[email protected]> Date: Mon Jan 8 17:44:30 2024 +0100 release: Amoy bootnodes (#9166) Cherry pick #9158 --------- Co-authored-by: Arpit Temani <[email protected]> commit a49fcb8 Author: Andrew Ashikhmin <[email protected]> Date: Fri Jan 5 13:03:28 2024 +0100 release params: remove dev from version (#9143)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the mumbai testnet node struggle to find peers. Before this fix in general test peer numbers are typically around 20 in total between eth66, eth67 and eth68. For new peers some can struggle to find even a single peer after days of operation.
These are the numbers after 12 hours or running on a node which previously could not find any peers: eth66=13, eth67=76, eth68=91.
The root cause of this issue is the following:
These issues case a significant number of discovery timeouts, some of the queries will never receive a response.
This causes the discovery read loop to enter a channel deadlock - which means that no responses are processed, nor timeouts fired. This causes the discovery process in the node to stop. From then on it just re-requests handshakes from a relatively small number of peers.
This check in fixes this situation with the following changes: