Parse activity type and use for automatic coloring #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik
reviewed
Sep 28, 2025
erik
reviewed
Sep 28, 2025
| 'walking': '#ff8800ff', | ||
| 'hiking': '#ff8800ff', | ||
| 'running': '#ff0000', | ||
| 'cycling': '#00ff00', |
There was a problem hiding this comment.
One more note actually -- could you keep the original colors here?
There was a problem hiding this comment.
For walking and hiking I changed to the original colors.
I still kept cycling now being green instead of cyan, as I added swimming as blue think the old cyan is very close to the default one and 3 blueish colors are hard to distinguish.
I'm still open to changing it to original behavior if this is important to you, though 😉 .
There was a problem hiding this comment.
Fair enough, no strong preference from me here. Feels like this should be customizable at some point anyway (not for this PR though)
This change adds activity type parsing functionality for the strava-supported file formats, i.e. GPX/TCX/FIT (https://developers.strava.com/docs/uploads/). Supported activity types are * ‘biking’ * ‘hiking’ * ‘running’ * ‘swimming’ * ‘walking’ Automatic coloring can still be disabled using the "Detect color from Strava bulk export" toggle in the UI. closes erik#71
|
Thx for the quick review @erik, pls see my comments above! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds activity type parsing functionality for the strava-supported file formats, i.e. GPX/TCX/FIT
(https://developers.strava.com/docs/uploads/).
Supported activity types are
Automatic coloring can still be disabled using the "Detect color from Strava bulk export" toggle in the UI.
closes #71