Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document bit_size in match-specs and allow in fun2ms #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sverker merged 1 commit into from
Oct 4, 2018
Merged

Document bit_size in match-specs and allow in fun2ms #1962

sverker merged 1 commit into from
Oct 4, 2018

Conversation

@gomoripeti
Copy link
Contributor

@gomoripeti gomoripeti commented Sep 25, 2018

It is already allowed in match-specs.

@gomoripeti
Document bit_size in match-specs and allow in fun2ms
8f7c468 
It is already allowed in match-specs.
@sverker sverker self-assigned this Sep 25, 2018
@sverker sverker added team:VM Assigned to OTP team VM fix labels Sep 25, 2018
@sverker
Copy link
Contributor

sverker commented Sep 25, 2018

May I suggest a rebase on maint for OTP-21.2.

git rebase --onto maint master

@gomoripeti gomoripeti changed the base branch from master to maint September 25, 2018 21:50
@gomoripeti
Copy link
Contributor Author

gomoripeti commented Sep 25, 2018

sorry, I chose the wrong target branch, now it should be maint

@sverker sverker added the testing currently being tested, tag is used by OTP internal CI label Sep 26, 2018
@sverker
Copy link
Contributor

sverker commented Sep 26, 2018

I see that byte_size is missing totally, but that would be another PR.

@gomoripeti
Copy link
Contributor Author

gomoripeti commented Sep 28, 2018

yes, byte_size is not even there in the PAM program interpreter. I wouldn't have dared to be so lazy to not add tests if I'd modified that part. And bit_size is good enough for most of (my) use-cases with bytestrings/Elixir strings.

@sverker sverker merged commit 0cb5456 into erlang:maint Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sverker sverker

Labels

fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gomoripeti @sverker