observer/etop: Calculate field width with available columns #5557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
956ef0a to
c677716
Compare
dgud
reviewed
Jan 18, 2022
lib/observer/src/etop_txt.erl
Outdated
Comment on lines
179
to
190
| ++ lists:duplicate(max(InitFunc - 16, 4), $ ) ++ | ||
| "Time" | ||
| ++ lists:duplicate(max(Reds - 4, 4), $ ) ++ | ||
| "Reds" | ||
| ++ lists:duplicate(max(Mem - 5, 3), $ ) ++ | ||
| "Memory" | ||
| ++ lists:duplicate(max(MsgQ - 3, 5), $ ) ++ | ||
| "MsgQ Current Function\n", |
Contributor
There was a problem hiding this comment.
Use '$\s' instead of '$ ' so we can see the space.
cc0601b to
2629486
Compare
Contributor
Author
|
Rebased on master. Should this maybe be rebased on |
Contributor
Please do |
Contributor
|
Looks good to me, when you have rebased, squash the commits. |
The field widths are calculated depending on what the underlying io driver reports as max column width. The fields are allowed to use the column width they need if they column budget allows it. The field widths are deducted in priority order and if there is space left the calculated width is used otherwise the default field width is used. If the underlying io driver can't give any column width, the default column width budget of 89 characters is used. This is the legacy hard coded width, plus two spaces between reductions, memory, and msgq fields. Fixes erlang#5080 Signed-off-by: Per Andersson <[email protected]>
2629486 to
1a4bfb2
Compare
Contributor
Author
|
Squashed and rebased on Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field widths are calculated depending on what the underlying io
driver reports as max column width.
The fields are allowed to use the column width they need if they column
budget allows it. The field widths are deducted in priority order and if
there is space left the calculated width is used otherwise the default
field width is used.
If the underlying io driver can't give any column width, the default
column width budget of 89 characters is used. This is the legacy hard
coded width, plus two spaces between reductions, memory, and msgq
fields.
Fixes #5080
Signed-off-by: Per Andersson [email protected]