Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tools] replace test_server:start_node with ?CT_PEER() #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rickard-green merged 1 commit into from
Feb 23, 2022
Merged

[tools] replace test_server:start_node with ?CT_PEER() #5566

rickard-green merged 1 commit into from
Feb 23, 2022

Conversation

@max-au
Copy link
Contributor

@max-au max-au commented Jan 1, 2022

Make tests more robust - node names can never clash now.

@garazdawi garazdawi added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Jan 3, 2022
@garazdawi garazdawi self-assigned this Jan 3, 2022
garazdawi
garazdawi reviewed Jan 3, 2022
View reviewed changes
@garazdawi garazdawi removed the testing currently being tested, tag is used by OTP internal CI label Jan 3, 2022
@max-au
[tools] replace test_server:start_node with ?CT_PEER()
ccc3ee8 
Make tests more robust - node names can never clash now.
@max-au max-au force-pushed the max-au/peerify-tools branch from 70b3ba2 to ccc3ee8 Compare January 7, 2022 17:38
@max-au
Copy link
Contributor Author

max-au commented Jan 7, 2022

  • kept emem_SUITE (to be removed in a separate PR)
  • added .idea to .gitignore (can be a separate PR, but why not...)
  • rebased to master to ensure no merge conflicts can happen

@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Jan 19, 2022
@garazdawi
Copy link
Contributor

garazdawi commented Jan 25, 2022

The reason why this is not merged yet is that we are chasing down a bug that manifests in cover_SUITE when this PR is run together with #5611.

@max-au
Copy link
Contributor Author

max-au commented Jan 25, 2022

Right, that diff still uses the test_server:start_node (mainly for the reason I haven't completed the big PR that peerifies kernel application). That is unfortunate, as I re-did global_SUITE significantly.

@garazdawi garazdawi removed the testing currently being tested, tag is used by OTP internal CI label Feb 14, 2022
@rickard-green rickard-green added the testing currently being tested, tag is used by OTP internal CI label Feb 18, 2022
@rickard-green rickard-green merged commit 6edca81 into erlang:master Feb 23, 2022
@max-au max-au deleted the max-au/peerify-tools branch September 30, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garazdawi garazdawi garazdawi left review comments

Assignees

@garazdawi garazdawi

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@max-au @garazdawi @rickard-green