Remove the ERLANG_COMPILE_DATE timestamp from erl_version.h #5589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was maybe used to generate erl_version.h in the past but it is not used in builds anymore, since replaced by the make_version script.
8901b59 to
86c84a4
Compare
Do not generate the ERLANG_COMPILE_DATE timestamp in erl_version.h with the make_version script to ensure reproducible builds. Remove the corresponding ERTS_SAVED_COMPILE_TIME option and update the configure scripts accordingly.
86c84a4 to
384e4a9
Compare
Contributor
Author
|
I've just pushed a minor change, simply updating the Copyright header date to 2022 in the modified files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not generate the
ERLANG_COMPILE_DATEtimestamp inerl_version.hwith themake_versionscript to ensure reproducible builds.While preparing this PR, I have found that
mkver.cseems totally unused in the builds, so the first commit removes this file.Linked to #4417