Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improper tag for private ED keys when encoding #5679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansN merged 1 commit into from
Feb 14, 2022
Merged

Improper tag for private ED keys when encoding #5679

HansN merged 1 commit into from
Feb 14, 2022

Conversation

@hauleth
Copy link
Contributor

@hauleth hauleth commented Feb 4, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022 •
edited
Loading

CT Test Results

       2 files       28 suites   13m 32s ⏱️
   429 tests    418 ✔️ 11 💤 0 ❌
1 631 runs  1 598 ✔️ 33 💤 0 ❌

Results for commit a1d78f2.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Feb 4, 2022
@HansN HansN removed their assignment Feb 4, 2022
@hauleth
Copy link
Contributor Author

hauleth commented Feb 4, 2022

Tests failed due to some errors on CI (C compiler cannot produce output).

@HansN HansN self-assigned this Feb 4, 2022
@HansN HansN added the testing currently being tested, tag is used by OTP internal CI label Feb 7, 2022
@HansN
Copy link
Contributor

HansN commented Feb 7, 2022

Good catch! I've added it to our internal tests, but it should be no problem I think.

The error in the Github CI seem to be something in the Erlang CI part itself since it's being re-made (I've reported it).

@HansN
Copy link
Contributor

HansN commented Feb 8, 2022

@hauleth Could you please rebase it onto maint so we also get it on OTP-24 and not only on the OTP-25 not yet released?

@IngelaAndin IngelaAndin added the waiting waiting for changes/input from author label Feb 9, 2022
@HansN HansN removed the testing currently being tested, tag is used by OTP internal CI label Feb 10, 2022
@hauleth
fix: improper tag for private ED keys when encoding
a1d78f2 
Documentation states that the tag is `ed_pri` not `ed_priv` for legacy
ED private keys [1].

[1]: https://erlang.org/doc/man/public_key.html#type-ed_private_key
@hauleth hauleth force-pushed the fix/improper-ssh-ed-tag branch from ed8eaee to a1d78f2 Compare February 11, 2022 11:12
@hauleth hauleth changed the base branch from master to maint February 11, 2022 11:13
@hauleth
Copy link
Contributor Author

hauleth commented Feb 11, 2022

@HansN done

@HansN HansN added testing currently being tested, tag is used by OTP internal CI and removed waiting waiting for changes/input from author labels Feb 11, 2022
@HansN HansN merged commit 1c8965a into erlang:maint Feb 14, 2022
@HansN
Copy link
Contributor

HansN commented Feb 14, 2022

Thanks for the PR!

@HansN HansN removed testing currently being tested, tag is used by OTP internal CI in progress labels Feb 14, 2022
@hauleth hauleth deleted the fix/improper-ssh-ed-tag branch June 6, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@HansN HansN

Labels

team:PS Assigned to OTP team PS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hauleth @HansN @IngelaAndin