kernel: Accept ver5 distribution connection setup #6625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 6 files 192 suites 1h 38m 12s ⏱️ For more details on these failures, see this check. Results for commit 2e9b56d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
We accept old 'send_name' handshake messages used by OTP-22 and older. OTP-23 or OTP-24 nodes, not using epmd, may send the old message to us if they do not know our OTP version. Hence, we accept the old 'send_name' and the accompanying 'send_complement', but we do not send them ourself. This was removed prematurely in OTP-25.0 by commit 722219f. Therefore versions 25.0 to 25.2.* are broken in this regard and may reject connection setup from OTP-23 and 24 not using epmd.
Partially reverts commit c804bd8.
Partially reverts cdd868b.
fd94665 to
2e9b56d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6595.
Make OTP-25 accept old
send_namehandshake messages used by OTP-22 and older. OTP-23 or OTP-24 nodes, not using epmd, may send the old message to us if they do not know our OTP version.Hence, we accept the old
send_nameand the accompanyingsend_complement, but we do not send them ourself.This was removed prematurely in OTP-25.0 by commit 722219f.
Therefore versions 25.0 to 25.2.* are broken in this regard and may reject connection setup from OTP-23 and 24 not using epmd.