inets: add type specifications #6661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 2 files 21 suites 12m 18s ⏱️ For more details on these failures, see this check. Results for commit 8cf960c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
c996ada to
7b8bda2
Compare
IngelaAndin
reviewed
Jan 17, 2023
IngelaAndin
reviewed
Jan 17, 2023
IngelaAndin
reviewed
Jan 17, 2023
IngelaAndin
reviewed
Jan 17, 2023
IngelaAndin
reviewed
Jan 17, 2023
Contributor
Author
|
This has been stalled a bit, but I plan on fixing all related issues this week :) |
346730f to
8ae46eb
Compare
8ae46eb to
c38f8bc
Compare
IngelaAndin
reviewed
Feb 15, 2023
IngelaAndin
approved these changes
Feb 16, 2023
Updates records, function headers, etc so that the `inets` app can be type checked by type checkers such as eqWAlizer.
0c5dcc0 to
8cf960c
Compare
KennethL
reviewed
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some type specifications to the
inetsmodule.These have been checked by Dialyzer and eqWAlizer.
Note: Not all types have been added because that would require bigger changes in
stdlib, but the ones that were possible have been added and are type checked by eqWalizer. The ones that are not possible usually refer to prop lists, because the return type in the spec is alwaysterm(), which makes eqWAlizer to think thatterm()is the input type to another function. When this other function expects (e.g.,)integer(), it reports a mismatch betweenterm()andinteger().