Thanks to visit codestin.com
Credit goes to github.com

Skip to content

inets: replace calls size/1 to XXX_size/1 #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kikofernandez merged 1 commit into from
Jan 16, 2023
Merged

inets: replace calls size/1 to XXX_size/1 #6670

kikofernandez merged 1 commit into from
Jan 16, 2023

Conversation

@kikofernandez
Copy link
Contributor

@kikofernandez kikofernandez commented Jan 16, 2023

Replace calls in the inets module from size/1 to tuple_size/1 or byte_size/1.
This PR is part of issue (PR) #6669

@kikofernandez kikofernandez self-assigned this Jan 16, 2023
@kikofernandez kikofernandez added team:PS Assigned to OTP team PS enhancement testing currently being tested, tag is used by OTP internal CI labels Jan 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023 •
edited
Loading

CT Test Results

No tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured.

Results for commit 0951e46

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kikofernandez kikofernandez force-pushed the kiko/inets/remove-calls-to-deprecated-size/OTP-18394 branch from d981259 to 0951e46 Compare January 16, 2023 08:36
bjorng
bjorng reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@bjorng bjorng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the is_tuple/1 test when you use tuple_size/1. Otherwise looks good.

@kikofernandez kikofernandez mentioned this pull request Jan 16, 2023
Closed
49 tasks
@kikofernandez kikofernandez force-pushed the kiko/inets/remove-calls-to-deprecated-size/OTP-18394 branch from f86fa99 to bc50f01 Compare January 16, 2023 09:54
@kikofernandez kikofernandez force-pushed the kiko/inets/remove-calls-to-deprecated-size/OTP-18394 branch from bc50f01 to bcf52f3 Compare January 16, 2023 09:55
@kikofernandez kikofernandez changed the title inets: remove calls to deprecated size/1 inets: replace calls size/1 to XXX_size/1 Jan 16, 2023
@kikofernandez kikofernandez merged commit 2a49eb7 into erlang:maint Jan 16, 2023
@kikofernandez kikofernandez deleted the kiko/inets/remove-calls-to-deprecated-size/OTP-18394 branch January 17, 2023 08:37
@kikofernandez kikofernandez removed the testing currently being tested, tag is used by OTP internal CI label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorng bjorng bjorng approved these changes

@IngelaAndin IngelaAndin IngelaAndin approved these changes

Assignees

@kikofernandez kikofernandez

Labels

enhancement team:PS Assigned to OTP team PS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kikofernandez @bjorng @IngelaAndin