Thanks to visit codestin.com
Credit goes to github.com

Skip to content

public_key: replace calls to size/1 function by XXX_size/1 #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kikofernandez merged 1 commit into from
Jan 16, 2023
Merged

public_key: replace calls to size/1 function by XXX_size/1 #6673

kikofernandez merged 1 commit into from
Jan 16, 2023

Conversation

@kikofernandez
Copy link
Contributor

@kikofernandez kikofernandez commented Jan 16, 2023 •
edited
Loading

Replace calls size/1 from the public_key module
#6672

@kikofernandez kikofernandez requested a review from bjorng January 16, 2023 09:30
@kikofernandez kikofernandez self-assigned this Jan 16, 2023
@kikofernandez kikofernandez added testing currently being tested, tag is used by OTP internal CI bug Issue is reported as a bug labels Jan 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023 •
edited
Loading

CT Test Results

    2 files    15 suites   4m 47s ⏱️
214 tests 212 ✔️ 2 💤 0 ❌
229 runs  227 ✔️ 2 💤 0 ❌

Results for commit 914c610.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kikofernandez kikofernandez mentioned this pull request Jan 16, 2023
Closed
49 tasks
@kikofernandez kikofernandez force-pushed the kiko/public_key/remove-calls-to-deprecated-size-function/OTP-18396 branch from 2772c43 to 914c610 Compare January 16, 2023 09:50
@kikofernandez kikofernandez changed the title public_key: remove calls to deprecated size function public_key: replace calls to size/1 function by XXX_size/1 Jan 16, 2023
bjorng
bjorng reviewed Jan 16, 2023
View reviewed changes
@kikofernandez kikofernandez force-pushed the kiko/public_key/remove-calls-to-deprecated-size-function/OTP-18396 branch from 914c610 to a7c7cbb Compare January 16, 2023 12:58
@kikofernandez
Copy link
Contributor Author

kikofernandez commented Jan 16, 2023

@bjorng Done!

@kikofernandez kikofernandez requested a review from bjorng January 16, 2023 12:59
@kikofernandez kikofernandez merged commit 07b6c45 into erlang:maint Jan 16, 2023
@kikofernandez kikofernandez deleted the kiko/public_key/remove-calls-to-deprecated-size-function/OTP-18396 branch January 16, 2023 13:58
@kikofernandez kikofernandez removed the testing currently being tested, tag is used by OTP internal CI label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorng bjorng bjorng approved these changes

Assignees

@kikofernandez kikofernandez

Labels

bug Issue is reported as a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kikofernandez @bjorng