Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ssh: replace size/1 by XXX_size/1 #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kikofernandez merged 2 commits into from
Jan 27, 2023
Merged

ssh: replace size/1 by XXX_size/1 #6696

kikofernandez merged 2 commits into from
Jan 27, 2023

Conversation

@kikofernandez
Copy link
Contributor

@kikofernandez kikofernandez commented Jan 17, 2023 •
edited
Loading

closes #6677

@kikofernandez kikofernandez added team:PS Assigned to OTP team PS feature testing currently being tested, tag is used by OTP internal CI labels Jan 17, 2023
@kikofernandez kikofernandez self-assigned this Jan 17, 2023
@kikofernandez kikofernandez mentioned this pull request Jan 17, 2023
Closed
49 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2023 •
edited
Loading

CT Test Results

       2 files       28 suites   17m 15s ⏱️
   447 tests    443 ✔️   4 💤 0 ❌
1 660 runs  1 634 ✔️ 26 💤 0 ❌

Results for commit 4cdaf25.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@kikofernandez kikofernandez linked an issue Jan 18, 2023 that may be closed by this pull request
ssh: Remove usage of size bif #6677
Closed
@IngelaAndin IngelaAndin requested review from u3s and removed request for IngelaAndin January 24, 2023 13:17
u3s
u3s approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@u3s u3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general comment. please have a look on changed lines. in few places you changed the line length which spoiled the indentation beneath it. please fix it.

In Emacs, it's enough to select region and press TAB.

@kikofernandez
Copy link
Contributor Author

kikofernandez commented Jan 27, 2023

Thanks for the feedback. I think I have solved all cases where the indentation was a bit off.
I will proceed with the merge :)

@kikofernandez kikofernandez merged commit 2d575a5 into erlang:maint Jan 27, 2023
@kikofernandez kikofernandez deleted the kiko/ssh/replace-size-by-xxx_size/GH-6677/OTP-18403 branch January 27, 2023 08:00
@kikofernandez kikofernandez mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@u3s u3s u3s approved these changes

Assignees

@kikofernandez kikofernandez

Labels

feature team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ssh: Remove usage of size bif

2 participants

@kikofernandez @u3s