-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: rename openssl/md5.h to avoid include conflicts with OpenSSL
#7989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CT Test Results 4 files 151 suites 48m 48s ⏱️ Results for commit d27de65. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
27f3265 to
f18dbbf
Compare
|
Hi @paulswartz! Thanks for the PR! Github CI does not pass, so it would seem like you have missed to update a couple of places? Could you also please rebase the change onto the |
f18dbbf to
eace72d
Compare
|
@garazdawi is there a way for me to force a build without the cache? The issue seems to happen here, but when it runs against CI on my fork the build passes: https://github.com/paulswartz/otp/actions/runs/7398429104/job/20127553489 |
|
Ah, is that was is causing the issues... getting a build cache correct is hard... If you add a commit with: To the |
|
@garazdawi thanks for the pointer! The build looks better now. |
|
Fix merged, will be part of next OTP-26 patch. I'm closing this PR manually as the fix will not be merged to maint-26 until the patch is actually released. Thanks for the fix! |
|
This fix is needed for OTP-25 too. FWIW I cherry-picked the three commits in this PR on top of OTP-25.3.2.14 and they applied cleanly and resolved the build problems I've seen on an M3 mac running Sonoma 14.6.1. |
|
It would be needed for version 24.3.4.17 as well, haven't been able to install on Sonoma 14.6 as well. |
Ref: #7987
I didn't look into it, but an alternate approach would be to use the OpenSSL implementation directly if OpenSSL is present (
--with-ssl).