Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@paulswartz
Copy link
Contributor

@paulswartz paulswartz commented Dec 31, 2023

Ref: #7987

I didn't look into it, but an alternate approach would be to use the OpenSSL implementation directly if OpenSSL is present (--with-ssl).

@CLAassistant
Copy link

CLAassistant commented Dec 31, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2023

CT Test Results

    4 files    151 suites   48m 48s ⏱️
1 627 tests 1 577 ✅ 50 💤 0 ❌
2 158 runs  2 089 ✅ 69 💤 0 ❌

Results for commit d27de65.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@garazdawi garazdawi added the team:VM Assigned to OTP team VM label Jan 2, 2024
@garazdawi
Copy link
Contributor

Hi @paulswartz! Thanks for the PR!

Github CI does not pass, so it would seem like you have missed to update a couple of places?

Could you also please rebase the change onto the maint-26 branch (git rebase --onto maint-26 HEAD~1) so that we can release the fix as a patch on OTP 26.

@paulswartz paulswartz changed the base branch from master to maint-26 January 3, 2024 14:21
@paulswartz
Copy link
Contributor Author

@garazdawi is there a way for me to force a build without the cache? The issue seems to happen here, but when it runs against CI on my fork the build passes: https://github.com/paulswartz/otp/actions/runs/7398429104/job/20127553489

@garazdawi
Copy link
Contributor

Ah, is that was is causing the issues... getting a build cache correct is hard...

If you add a commit with:

- deleted: '**.h'

To the no-cache filter it will skip using the cache whenever anyone deletes a .h file.

@paulswartz
Copy link
Contributor Author

@garazdawi thanks for the pointer! The build looks better now.

@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Jan 8, 2024
@garazdawi
Copy link
Contributor

Fix merged, will be part of next OTP-26 patch. I'm closing this PR manually as the fix will not be merged to maint-26 until the patch is actually released.

Thanks for the fix!

@garazdawi garazdawi closed this Jan 15, 2024
@mikpe
Copy link
Contributor

mikpe commented Sep 23, 2024

This fix is needed for OTP-25 too.

FWIW I cherry-picked the three commits in this PR on top of OTP-25.3.2.14 and they applied cleanly and resolved the build problems I've seen on an M3 mac running Sonoma 14.6.1.

@dvkch
Copy link

dvkch commented Nov 4, 2024

It would be needed for version 24.3.4.17 as well, haven't been able to install on Sonoma 14.6 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macOS Sonoma] cannot compile 26.2.*: undefined symbols _ei_MD5Final _ei_MD5Init _ei_MD5Update

5 participants