Try fix race in erlang:halt #8640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 3 files 143 suites 48m 36s ⏱️ Results for commit 12c312f. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Contributor
Author
|
@jhogberg Could it be this simple or am I missing something? |
If two or more processes calls halt it seems the yielded dummy call halt(undefined,undefined) can actually happen. Suspend the calling process to make sure it does get scheduled again.
into sverker/27/erts/halt-race-fix/OTP-19490
a3201e7 to
12c312f
Compare
garazdawi
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8634
If two or more processes calls
haltit seems the yielded dummy callhalt(undefined,undefined)can actually happen.Suspend the calling process to make sure it does not get scheduled again.