Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@VlkrS
Copy link
Contributor

@VlkrS VlkrS commented Dec 2, 2024

This is an attempt to resolve #9000

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

CT Test Results

  2 files   14 suites   5m 39s ⏱️
186 tests 172 ✅  14 💤 0 ❌
459 runs  329 ✅ 130 💤 0 ❌

Results for commit 4da9a09.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Dec 9, 2024
@sverker sverker added fix testing currently being tested, tag is used by OTP internal CI labels Dec 9, 2024
@sverker sverker self-requested a review December 9, 2024 12:45
@sverker
Copy link
Contributor

sverker commented Dec 11, 2024

@VlkrS This looks good. Have you tested it yourself with LibreSSL that it solves the problem?

sverker
sverker previously approved these changes Dec 11, 2024
@VlkrS
Copy link
Contributor Author

VlkrS commented Dec 11, 2024

@VlkrS This looks good. Have you tested it yourself with LibreSSL that it solves the problem?

Yes, I tested with the OpenBSD port of OTP 27. I didn't test on other platforms than that, however.

@sverker sverker changed the base branch from master to maint December 12, 2024 17:39
@sverker
Copy link
Contributor

sverker commented Dec 12, 2024

I squashed it into one commit and rebased on maint branch to be released in OTP 27.3.

@sverker sverker merged commit d781fe8 into erlang:maint Dec 16, 2024
23 checks passed
@sverker
Copy link
Contributor

sverker commented Dec 16, 2024

@VlkrS Does this sound ok as release note:

Allow for ED25519 and X25519 being available without ED448 and X448, which is the case in LibreSSL. This is necessary for supporting TLS1.3 using LibreSSL.

@VlkrS
Copy link
Contributor Author

VlkrS commented Dec 17, 2024

@VlkrS Does this sound ok as release note:

Allow for ED25519 and X25519 being available without ED448 and X448, which is the case in LibreSSL. This is necessary for supporting TLS1.3 using LibreSSL.

lgtm, thanks!

@VlkrS VlkrS deleted the eddh branch December 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto: Allow for ed25519/x25519 being available without ed448/x448

3 participants