Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stdlib: Fix argparse:format_help/2 crash on 'hidden' command #9151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garazdawi merged 1 commit into from
Dec 17, 2024
Merged

stdlib: Fix argparse:format_help/2 crash on 'hidden' command #9151

garazdawi merged 1 commit into from
Dec 17, 2024

Conversation

@sg2342
Copy link
Contributor

@sg2342 sg2342 commented Dec 6, 2024

Fixes #9150

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

CT Test Results

    2 files     95 suites   1h 8m 16s ⏱️
2 158 tests 2 110 ✅ 48 💤 0 ❌
2 517 runs  2 467 ✅ 50 💤 0 ❌

Results for commit b2b2331.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

max-au
max-au approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@max-au max-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for adding the test case for explicitly added sub-command. Looks good to me.

@garazdawi garazdawi self-assigned this Dec 6, 2024
@garazdawi garazdawi added team:VM Assigned to OTP team VM fix labels Dec 6, 2024
@garazdawi
Copy link
Contributor

garazdawi commented Dec 10, 2024

Thanks for the fix. I will merge this to maint for release in 27.3 as soon as 27.2 is out.

@garazdawi garazdawi added this to the OTP-27.3 milestone Dec 10, 2024
@garazdawi garazdawi changed the base branch from master to maint December 13, 2024 07:53
@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Dec 13, 2024
@garazdawi
Copy link
Contributor

garazdawi commented Dec 13, 2024

I did a rebase of your commit to maint for inclusion into 27.3. Added to nightly tests and will merge next week if nothing pops up.

@garazdawi garazdawi added testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Dec 16, 2024
@garazdawi garazdawi merged commit e049e87 into erlang:maint Dec 17, 2024
24 checks passed
@garazdawi
Copy link
Contributor

garazdawi commented Dec 17, 2024

Thanks!

@sg2342 sg2342 deleted the argparse_regression branch December 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garazdawi garazdawi garazdawi approved these changes

+1 more reviewer

@max-au max-au max-au approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@garazdawi garazdawi

Labels

fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

OTP-27.3

Development

Successfully merging this pull request may close these issues.

argparse crash in format_help for hidden commands

3 participants

@sg2342 @garazdawi @max-au