ssl: Fix function_clause error in tls_server_connection_1_3:select_server_cert_key_pair function #9185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
CT Test Results 1 files 11 suites 4m 16s ⏱️ Results for commit ac294e8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
The error occurs if more than one certificate is configured and the first certificate fails the check by the tls_handshake_1_3:check_cert_sign_algo function. The recursive call to the select_server_cert_key_pair function fails and as a result the TLS connection is not established.
57f195a to
ac294e8
Compare
IngelaAndin
approved these changes
Jan 9, 2025
Contributor
|
@nikita-v This was obviously correct. And although maybe we should add some further tests I like to get this in master too where I will get automatic cover runs to help analyze it. Thanks for providing the fix, if you have any ide for a testcase you are welcome to contribute, thank you for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error occurs if more than one certificate is configured and the first certificate fails the check by the
tls_handshake_1_3:check_cert_sign_algofunction. The recursive call to theselect_server_cert_key_pairfunction fails and as a result the TLS connection is not established.