Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ssh: Fix ssh_sftp:start_channel/2 spec #9368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexandrejbr wants to merge 2 commits into from
Closed

ssh: Fix ssh_sftp:start_channel/2 spec #9368

alexandrejbr wants to merge 2 commits into from

Conversation

@alexandrejbr
Copy link
Contributor

@alexandrejbr alexandrejbr commented Jan 31, 2025 •
edited
Loading

Fixes #9359

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

CT Test Results

    2 files     29 suites   19m 34s ⏱️
  464 tests   460 ✅  4 💤 0 ❌
1 669 runs  1 645 ✅ 24 💤 0 ❌

Results for commit a04a22c.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@alexandrejbr alexandrejbr force-pushed the alexandrejbr/fix-ssh_sftp-start_channel-spec branch from 9545ba3 to a1b8063 Compare January 31, 2025 12:34
@u3s u3s self-assigned this Jan 31, 2025
@u3s u3s added the team:PS Assigned to OTP team PS label Jan 31, 2025
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Feb 3, 2025
@u3s
Copy link
Contributor

u3s commented Feb 6, 2025

FYI, this PR has been merged to maint and master in f9ad902

@alexandrejbr
Copy link
Contributor Author

alexandrejbr commented Feb 26, 2025

@u3s I don't seem to find this change in the newest OTP-27 maintenance releases: https://github.com/erlang/otp/blob/OTP-27.2.4/lib/ssh/src/ssh_sftp.erl#L157

Should I have targeted a different branch?

@dgud
Copy link
Contributor

dgud commented Feb 26, 2025 •
edited
Loading

If it is merged to maint and master it will appear in 27.3 and 28.

@u3s
Copy link
Contributor

u3s commented Mar 4, 2025

yes, I treated this as a doc update/fix not a code bug. so 27.3 (next upcoming maintenance patch) and later 28.0.

note, 27.2.4 is emergency/security patch - containing only bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@u3s u3s u3s approved these changes

Assignees

@u3s u3s

Labels

team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandrejbr @u3s @dgud