Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented May 25, 2025

Description

At the moment this is created (as a Draft) most tests are passing locally, but I want to check behaviour in GHA CI as one would use the action.

Closes #54.

Further considerations

I took the time/chance to also act on some stuff the sec. bot found. The commits are easily identifiable.

I also retired 18.04 and 20.04 in this pull request since you can no longer consume them in GHA, apparently.

@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the feature/support-macos branch 3 times, most recently from 4151385 to c9d7c22 Compare May 25, 2025 20:57
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the feature/support-macos branch 4 times, most recently from 904cea0 to 0b10410 Compare May 25, 2025 21:44
Comment on lines +21 to +22
permissions:
contents: write
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was GitHub. If you prefer I can push in a separate pull request to separate concerns.

Comment on lines +44 to +45
permissions:
contents: read
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was GitHub. If you prefer I can push in a separate pull request to separate concerns.

Comment on lines +21 to +22
otp-version: ['27']
elixir-version: ['v1.18', '']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took this time to bump these to more recent versions.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review May 25, 2025 21:58
Copy link
Collaborator

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulo-ferraz-oliveira
Copy link
Collaborator Author

There's a minor doc. update requirement, but apart from that we seem good to go.

Co-authored-by: Wojtek Mach <[email protected]>
@paulo-ferraz-oliveira
Copy link
Collaborator Author

If CI's passing, I'm merging. I don't think there's hurry in releasing, since we have a couple of ongoing PRs, but I'm Ok to release nonetheless.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 58f0e7a into main May 29, 2025
72 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/support-macos branch May 29, 2025 10:38
@paulo-ferraz-oliveira
Copy link
Collaborator Author

This was released in v1.20.0.

@petermm
Copy link

petermm commented Jun 24, 2025

we are experiencing broad CI breakage due to the removal of ubuntu20: https://github.com/atomvm/AtomVM/actions/runs/15860728250/job/44717019321?pr=1728#step:8:25

note that we are using github container feature: https://github.com/atomvm/AtomVM/blob/082defb9cb916f8232d9886787ab10b4ed21bec3/.github/workflows/build-and-test.yaml#L61

suggest adding ubuntu20 (and presumably ubuntu18) back in.. do you want a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add action for macOS

4 participants