Use the correct length in text for parsing #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnicodeCharsXXTextRecord is encoded as UTF-16 and the length refers to the length in encoded bytes not Unicode. This meant that records of length > 128 Unicode characters could fail to convert to binary elsewhere because the length couldn't fit in the record (but it varied on the length). (Changing this code to use the alternate CharsXXTextRecord with UTF-8 might also be useful for saving space)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnicodeCharsXXTextRecord is encoded as UTF-16 and the length refers to the length in encoded bytes not Unicode. This meant that records of length > 128 Unicode characters could fail to convert to binary elsewhere because the length couldn't fit in the record (but it varied on the length).
(Changing this code to use the alternate CharsXXTextRecord with UTF-8 might also be useful for saving space)