DatetimeTextRecord isn't handled correctly #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation was assuming big-endian ordering of the tz and value bits but it should be little-endian.
bluec0re
added a commit
that referenced
this pull request
Dec 19, 2014
DatetimeTextRecord isn't handled correctly
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the datetime records I'm receiving from our .NET services and also based on the spec and examples at http://msdn.microsoft.com/en-us/library/cc219284.aspx, DatetimeTextRecord has the bit order wrong for the value and tz components.
I've added tests to the to_bytes() and parse() methods and my fix to the bit handling.
Best,
Stefan