-
Notifications
You must be signed in to change notification settings - Fork 4
hot water zone compatibility bug fix #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Still related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this! I don't think the Optional is needed, where as a default value is always assigned. Unless I am overlooking something? :)
Co-authored-by: Erwin Douna <[email protected]>
Co-authored-by: Erwin Douna <[email protected]>
Co-authored-by: Erwin Douna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ethemcemozkan!
Proposed Changes
Please see my comments in the HA PR home-assistant/core#121503 (comment)
Due to missing hot water zone attributes(dazzleMode enabled and open_window_detection enabled timeout_in_seconds), integration setup flow was failing. I made these local changes to fix the issue. Feel free to let me know if you have a better idea.
Related Issues