Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ethemcemozkan
Copy link
Contributor

Proposed Changes

Please see my comments in the HA PR home-assistant/core#121503 (comment)

Due to missing hot water zone attributes(dazzleMode enabled and open_window_detection enabled timeout_in_seconds), integration setup flow was failing. I made these local changes to fix the issue. Feel free to let me know if you have a better idea.

Related Issues

(Github link to related issues or pull requests)

Copy link

github-actions bot commented Oct 2, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 2, 2024
@ethemcemozkan
Copy link
Contributor Author

Still related

@github-actions github-actions bot removed the stale label Oct 3, 2024
Copy link
Owner

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this! I don't think the Optional is needed, where as a default value is always assigned. Unless I am overlooking something? :)

ethemcemozkan and others added 4 commits October 19, 2024 18:03
Co-authored-by: Erwin Douna <[email protected]>
Co-authored-by: Erwin Douna <[email protected]>
Co-authored-by: Erwin Douna <[email protected]>
@erwindouna erwindouna added enhancement Enhancement of the code, not introducing new features refactor Improvement of existing code, not introducing new features labels Oct 20, 2024
Copy link
Owner

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ethemcemozkan!

@erwindouna erwindouna merged commit 0aa8608 into erwindouna:main Oct 20, 2024
11 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@ethemcemozkan ethemcemozkan deleted the patch-1 branch February 11, 2025 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Enhancement of the code, not introducing new features refactor Improvement of existing code, not introducing new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants