Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix(comments): Escapes @ symbols in code blocks - #436

Merged
h13i32maru merged 1 commit into
esdoc:masterfrom
pzuraq:bugfix/properly-escape-descriptions
Sep 3, 2017
Merged

bugfix(comments): Escapes @ symbols in code blocks#436
h13i32maru merged 1 commit into
esdoc:masterfrom
pzuraq:bugfix/properly-escape-descriptions

Conversation

@pzuraq

@pzuraq pzuraq commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

@ symbols inside code blocks are currently mistakenly interpreted as tags, making it difficult to have code examples for decorators. This PR escapes them, rather naively. Willing to try to do a better fix, but since this code is marked for refactor I figure @h13i32maru has plans for it anyways.

@pzuraq
pzuraq force-pushed the bugfix/properly-escape-descriptions branch from 0daea3c to 304410a Compare June 27, 2017 01:13
@pzuraq

pzuraq commented Jun 27, 2017

Copy link
Copy Markdown
Contributor Author

Fixed the regex

@h13i32maru h13i32maru left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h13i32maru
h13i32maru merged commit 501d9f4 into esdoc:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants