Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Apr 4, 2024

This intentionally targets the v8.x branch.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Ports #18260 to v8.x.

What changes did you make? (Give an overview)

Copied docs/ changes from #18260.

Build-related changes are intentionally omitted as they're not important for this branch.

The following code is also intentionally omitted as it was necessary only for testing of #18260 (I'll remove it from the main branch as well):

// For initial commit purpose only
if (items.length === 0) {
const localData = require("./versions.json");
items.push(...localData.items);
}

The same for docs/src/_data/versions.json.

Is there anything you'd like reviewers to focus on?

If we'll release another prerelease this week, I'll manually sync the latest branch with the v8.x branch when this is merged. - edit: no need for updating the latest branch manually as we're releasing v9.0.0 final and the latest branch will be synced with the main branch where this has already been implemented.

@mdjermanovic mdjermanovic requested a review from a team as a code owner April 4, 2024 19:38
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

βœ… Deploy Preview for docs-eslint ready!

Name Link
πŸ”¨ Latest commit 6c93e8b
πŸ” Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/660f01b0abc06d00084fad99
😎 Deploy Preview https://deploy-preview-18265--docs-eslint.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 4, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just leaving open so @mdjermanovic can merge when ready.

@mdjermanovic
Copy link
Member Author

Safe to merge now, and we'll need this to test eslint/eslint.org#541.

@mdjermanovic mdjermanovic merged commit c68c07f into v8.x Apr 4, 2024
@mdjermanovic mdjermanovic deleted the v8-issue18229 branch April 4, 2024 22:10
Vylpes pushed a commit to Vylpes/card-drop that referenced this pull request Sep 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | patch | [`8.57.0` -> `8.57.1`](https://renovatebot.com/diffs/npm/eslint/8.57.0/8.57.1) |

---

### Release Notes

<details>
<summary>eslint/eslint (eslint)</summary>

### [`v8.57.1`](https://github.com/eslint/eslint/releases/tag/v8.57.1)

[Compare Source](eslint/eslint@v8.57.0...v8.57.1)

#### Bug Fixes

-   [`a19072f`](eslint/eslint@a19072f) fix: add logic to handle fixTypes in the lintText() method ([#&#8203;18900](eslint/eslint#18900)) (Francesco Trotta)
-   [`04c7188`](eslint/eslint@04c7188) fix: Don't lint same file multiple times ([#&#8203;18899](eslint/eslint#18899)) (Francesco Trotta)
-   [`87ec3c4`](eslint/eslint@87ec3c4) fix: do not throw when defining a global named `__defineSetter__` ([#&#8203;18898](eslint/eslint#18898)) (Francesco Trotta)
-   [`60a1267`](eslint/eslint@60a1267) fix: Provide helpful error message for nullish configs ([#&#8203;18889](eslint/eslint#18889)) (Milos Djermanovic)
-   [`a0dea8e`](eslint/eslint@a0dea8e) fix: allow `name` in global ignores, fix `--no-ignore` for non-global ([#&#8203;18875](eslint/eslint#18875)) (Milos Djermanovic)
-   [`3836bb4`](eslint/eslint@3836bb4) fix: do not crash on error in `fs.walk` filter ([#&#8203;18886](eslint/eslint#18886)) (Milos Djermanovic)
-   [`2dec349`](eslint/eslint@2dec349) fix: skip processor code blocks that match only universal patterns ([#&#8203;18880](eslint/eslint#18880)) (Milos Djermanovic)

#### Documentation

-   [`6a5add4`](eslint/eslint@6a5add4) docs: v8.x Add EOL banner ([#&#8203;18744](eslint/eslint#18744)) (Amaresh  S M)
-   [`b034575`](eslint/eslint@b034575) docs: v8.x add version support page to the dropdown ([#&#8203;18731](eslint/eslint#18731)) (Amaresh  S M)
-   [`760ef7d`](eslint/eslint@760ef7d) docs: v8.x add version support page in the side navbar ([#&#8203;18740](eslint/eslint#18740)) (Amaresh  S M)
-   [`428b7ea`](eslint/eslint@428b7ea) docs: Add Powered by Algolia label to the search ([#&#8203;18658](eslint/eslint#18658)) (Amaresh  S M)
-   [`c68c07f`](eslint/eslint@c68c07f) docs: version selectors synchronization ([#&#8203;18265](eslint/eslint#18265)) (Milos Djermanovic)

#### Build Related

-   [`35d366a`](eslint/eslint@35d366a) build: Support updates to previous major versions ([#&#8203;18870](eslint/eslint#18870)) (Milos Djermanovic)

#### Chores

-   [`140ec45`](eslint/eslint@140ec45) chore: upgrade [@&#8203;eslint/js](https://github.com/eslint/js)[@&#8203;8](https://github.com/8).57.1 ([#&#8203;18913](eslint/eslint#18913)) (Milos Djermanovic)
-   [`bcdfc04`](eslint/eslint@bcdfc04) chore: package.json update for [@&#8203;eslint/js](https://github.com/eslint/js) release (Jenkins)
-   [`3f6ce8d`](eslint/eslint@3f6ce8d) chore: pin [email protected] ([#&#8203;18910](eslint/eslint#18910)) (Milos Djermanovic)
-   [`9f07549`](eslint/eslint@9f07549) chore: ignore `/docs/v8.x` in link checker ([#&#8203;18660](eslint/eslint#18660)) (Milos Djermanovic)

</details>

---

### Configuration

πŸ“… **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.vylpes.xyz/External/card-drop/pulls/366
Reviewed-by: Vylpes <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 2, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants