feat: add suggestions for no-unused-private-class-members#20773
Merged
DMartens merged 5 commits intoApr 27, 2026
Conversation
Closed
3 tasks
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DMartens
reviewed
Apr 21, 2026
DMartens
reviewed
Apr 21, 2026
DMartens
reviewed
Apr 21, 2026
DMartens
reviewed
Apr 21, 2026
DMartens
reviewed
Apr 21, 2026
DMartens
reviewed
Apr 23, 2026
mdjermanovic
approved these changes
Apr 27, 2026
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! I think that removing comments works good for common comment placements & code formatting, and reasonably well in edge case. Since these are suggestions, in edge cases where unwanted comments might be left in the code user can remove them manually after applying the suggested fix.
Leaving open for @DMartens to verify.
DMartens
approved these changes
Apr 27, 2026
Contributor
DMartens
left a comment
There was a problem hiding this comment.
Changes LGTM, thank you for working on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR adds suggestions to
no-unused-private-class-membersfor unused private fields and methods when the member can be safely removed.Fixes #20516
Is there anything you'd like reviewers to focus on?