Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(no-unsupported): Correctly handle recursive objects on a per module basis #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(no-unsupported): Correctly handle recursive objects on a per module basis #396

merged 2 commits into from
Dec 10, 2024

Conversation

scagood
Copy link

@scagood scagood commented Dec 9, 2024 •
edited
Loading

Closes #395

This prevents the recusrion protection from blocking module alias publishing.

We look to have been missing 6 options from the ignores list 😱

Valid ignores Count
Before 1462
After 1468

@scagood scagood added bug rule:update An update to a current rule labels Dec 9, 2024
@scagood scagood requested a review from a team December 9, 2024 16:34
aladdin-add
aladdin-add approved these changes Dec 10, 2024
View reviewed changes
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@aladdin-add aladdin-add merged commit db384d1 into eslint-community:master Dec 10, 2024
29 checks passed
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
bug rule:update An update to a current rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: In the no-unsupported-features/node-builtins rule, certain module names containing "/" cannot be properly suppressed.
2 participants
@scagood @aladdin-add