Thanks to visit codestin.com
Credit goes to github.com

Skip to content

task 2 - added hover backend implementation & tk specific label #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2023

Conversation

yanxinc
Copy link
Collaborator

@yanxinc yanxinc commented Apr 28, 2023

PR Summary

This is in relation to the second task in issue matplotlib#23378. We added a label of coordinates upon hovering over artists. This PR adds the associated hover methods in the artist, creates connections between mouseevents and the hover method, and adds relevant hover message labels in the tk backend.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@eslothower
Copy link
Owner

Looks like there are some methods that are not included in the stub. This should be fixed before we merge these changes, as they are different than linter errors. Including these methods in the stub should fix the Mypy Stubtest tests. I had this same issue with my first PR, but I fixed it before this PR was started, so we should look into why these methods weren't included in the stub from my merged PR. Might be a weird .gitignore thing

@eslothower eslothower merged commit 844fcc8 into main Apr 30, 2023
@eslothower eslothower added the enhancement New feature or request label May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants