Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove figure not None check #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2023
Merged

Remove figure not None check #4

merged 1 commit into from
May 6, 2023

Conversation

pm3512
Copy link
Collaborator

@pm3512 pm3512 commented May 3, 2023

PR summary

Removes ValueError raised when figure is not provided

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@pm3512 pm3512 changed the title removed check Remove figure not None check May 3, 2023
@symbolic23 symbolic23 self-requested a review May 6, 2023 08:06
Copy link
Collaborator

@symbolic23 symbolic23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct change, thank you!

@symbolic23 symbolic23 merged commit 028dd77 into main May 6, 2023
@eslothower eslothower added the documentation Improvements or additions to documentation label May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants