Add no_addresses monitor flag
#942
Merged
+376
−363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --no-addresses flag to the monitor command to disable address resolution for smaller log output. The change allows users to skip loading symbols and function name lookups to reduce output verbosity.
- Added a new
no_addressesboolean field toMonitorConfigArgs - Created a new constructor
new_no_addressesforResolvingPrinterthat disables symbol loading and address resolution - Updated monitor logic to conditionally create the appropriate printer based on the flag
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| espflash/src/cli/mod.rs | Adds the no_addresses command-line flag to MonitorConfigArgs |
| espflash/src/cli/monitor/mod.rs | Updates monitor function to use the new flag and includes it in monitor args checking |
| espflash/src/cli/monitor/parser/mod.rs | Adds disable_address_resolution field and new_no_addresses constructor to ResolvingPrinter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
043168e to
879c4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.