move padding to 4 bytes from CLI into library #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56dfae4 to
de74eda
Compare
Downstream applications needed to duplicate the padding to 4 bytes logic that the CLI application does (although that requirement was not documented). Otherwise flashing could fail with a RomError with error code 0.
de74eda to
b4b05df
Compare
SergioGasquez
approved these changes
Sep 18, 2025
|
Thanks for the quick review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream applications needed to duplicate the padding to 4 bytes logic that the CLI application does (although that requirement was not documented). Otherwise flashing could fail with a RomError with error code 0.