Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HTTPS GET Request returns -1 (still worked with Git update on Jun 6, 2016) #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djoele opened this issue Jun 14, 2016 · 6 comments
Closed

HTTPS GET Request returns -1 (still worked with Git update on Jun 6, 2016) #2150

djoele opened this issue Jun 14, 2016 · 6 comments
Labels
component: libraries type: bug
Milestone
2.3.0

Comments

@djoele
Copy link

djoele commented Jun 14, 2016 •
edited by igrr
Loading

Hello everybody,

today I updated the ESP8266 code from Github.

My latest update was:
commit 32bd42b, June 6th

Now I have:
commit da17d54, Jun 14th

I have the function below which is responsible for doing a HTTPS GET Request.
The behaviour that I see now is that http=>GET now always returns -1.
When I do the request from a browser it is working and returns 200.

Anybody sees what I am doing wrong? Were there any changes in the ESP8266 codebase that forces me to change something?

const char* url= "https://....";
const String host = ".....";
const int port = 443;
const char * fingerprint = ".....";
const char* www_username = "....";
const char* www_password = ".....";

callURL(url, host, port);

  void callURL(String url, String host, const int port) {
      HTTPClient * http = new HTTPClient();
      http->begin(host, port, url, fingerprint);
      http->setAuthorization(www_username,www_password);
      http->addHeader("X-ESP8266-IP", ipadres);

      int httpCode = http->GET();
      Serial.println((String("[HTTP] url: ") + url + ", return code: " + httpCode));
      http->end();
     http->~HTTPClient();
     delete http;
}

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@djoele djoele changed the title HTTPS GET Request returns -1 HTTPS GET Request returns -1 (still worked with GIt update on Jun 6, 2016) Jun 14, 2016
@djoele djoele changed the title HTTPS GET Request returns -1 (still worked with GIt update on Jun 6, 2016) HTTPS GET Request returns -1 (still worked with Git update on Jun 6, 2016) Jun 14, 2016
igrr added a commit that referenced this issue Jun 15, 2016
@igrr
Fix regression in WiFiClientSecure, update HTTPS test case (#2150)
e64e32b
@igrr igrr added this to the 2.3.0 milestone Jun 15, 2016
@djoele
Copy link
Author

djoele commented Jun 15, 2016

Thank you for the fast response and possible fix. Tonight I will check if it works and report back.

@djoele
Copy link
Author

djoele commented Jun 15, 2016 •
edited
Loading

I tried with the latest fix and it is working.
Issue resolved.

Thank you.

@HTDemon
Copy link

HTDemon commented Jun 17, 2016

Hi, I got similar issue connect to Slack HTTPS API and tried 2.3.0-rc2, 2.3.0-rc1, 2.2.0 and 2.1.0.

I tried http.begin(String url, String httpsFingerprint) and http.begin(String url) with 2.3.0-rc2
http.begin("https://slack.com/api/rtm.start?token=" SLACK_BOT_TOKEN, httpsFingerprint); int httpCode = http.GET();

debug log:

[HTTP-Client][begin] url: https://slack.com/api/rtm.start?token=...
[HTTP-Client][begin] host: slack.com port: 443 url: /api/rtm.start?token=...
[HTTP-Client][begin] httpsFingerprint: ....
[hostByName] request IP for: slack.com
[hostByName] Host: slack.com IP: ....
[HTTP-Client] connected to slack.com:443
[HTTP-Client][handleHeaderResponse] RX: 'HTTP/1.1 200 OK'
[HTTP-Client][handleHeaderResponse] RX: 'Content-Type: application/json; charset=utf-8'
[HTTP-Client][handleHeaderResponse] RX: 'Transfer-Encoding: chunked'
[HTTP-Client][handleHeaderResponse] RX: 'Connection: close'
[HTTP-Client][handleHeaderResponse] RX: 'Access-Control-Allow-Origin: *'
[HTTP-Client][handleHeaderResponse] RX: 'Cache-Control: private, no-cache, no-store, must-revalidate'
[HTTP-Client][handleHeaderResponse] RX: 'Content-Security-Policy: referrer no-referrer;'
[HTTP-Client][handleHeaderResponse] RX: 'Date: Fri, 17 Jun 2016 08:09:33 GMT'
[HTTP-Client][handleHeaderResponse] RX: 'Expires: Mon, 26 Jul 1997 05:00:00 GMT'
[HTTP-Client][handleHeaderResponse] RX: 'Pragma: no-cache'
[HTTP-Client][handleHeaderResponse] RX: 'Server: Apache'
[HTTP-Client][handleHeaderResponse] RX: 'Strict-Transport-Security: max-age=31536000; includeSubDomains; preload'
[HTTP-Client][handleHeaderResponse] RX: 'Vary: Accept-Encoding'
[HTTP-Client][handleHeaderResponse] RX: 'X-Accepted-OAuth-Scopes: rtm:stream,client'
[HTTP-Client][handleHeaderResponse] RX: 'X-Content-Type-Options: nosniff'
[HTTP-Client][handleHeaderResponse] RX: 'X-OAuth-Scopes: identify,read,post,client,apps'
[HTTP-Client][handleHeaderResponse] RX: 'X-XSS-Protection: 0'
[HTTP-Client][handleHeaderResponse] RX: 'X-Cache: Miss from cloudfront'
[HTTP-Client][handleHeaderResponse] RX: 'Via: 1.1 35436fa36ed8ec21d3998280f7181e8b.cloudfront.net (CloudFront)'
[HTTP-Client][handleHeaderResponse] RX: 'X-Amz-Cf-Id: a6Z4JVv6s10ya6L3I3C0xpLr6tgk-JLmjA2aJrUA62148qwMv-A9dQ=='
[HTTP-Client][handleHeaderResponse] RX: ''
[HTTP-Client][handleHeaderResponse] code: 200
[HTTP-Client][handleHeaderResponse] Transfer-Encoding: chunked
[HTTP-Client][end] still data in buffer (2121), clean up.
check_poison_block is called for free block 0x3fff5b48
Exception (3):
epc1=0x4010011d epc2=0x00000000 epc3=0x00000000 excvaddr=0x40039030 depc=0x00000000

http.begin("https://slack.com/api/rtm.start?token=" SLACK_BOT_TOKEN); int httpCode = http.GET();

debug log:

[HTTP-Client][begin] url: https://slack.com/api/rtm.start?token=....
[HTTP-Client][begin] unexpected protocol: https, expected http
[HTTP-Client] connect: HTTPClient::begin was not called or returned error
[HTTP-Client][returnError] error(-1): connection refused
[HTTP-Client][end] tcp is closed
HTTP GET failed with code -1

@igrr
Copy link
Member

igrr commented Jun 17, 2016 •
edited
Loading

I think this is different issue, you are receiving Exception 3.
Doing a request to HTTPS URL without fingerprint (your second test) should not work, the error you are getting is "unexpected protocol: https, expected http". This is because no fingerprint was supplied.
Please open a new issue for your first problem. If possible, please provide complete sketch to reproduce this.

@igrr igrr closed this as completed Jun 17, 2016
@igrr igrr reopened this Jun 17, 2016
@igrr igrr closed this as completed Jun 23, 2016
@akshaykankal
Copy link

@djoele How did you solve it?
Can you post the solution here?

@djoele
Copy link
Author

djoele commented Oct 23, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: libraries type: bug
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
4 participants
@igrr @djoele @HTDemon @akshaykankal