Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Extend Print class for 64bit integers. #7040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2020
Merged

Extend Print class for 64bit integers. #7040

merged 5 commits into from
Oct 1, 2020

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Jan 28, 2020

@d-a-v We've talked about it yesterday. Even if PR'ing AVR Arduino is a good idea to do first|also, could you give this an eye, please?
Compiled size is not affected if not used with (u)int64_t, if print(int64_t) gets used, 288 bytes IROM are used additionally.

d-a-v
d-a-v approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !
Is the new modulo code smaller than the former substract-multiply ?

@dok-net
Copy link
Contributor Author

dok-net commented Jan 29, 2020 •
edited
Loading

On AVR (arduino/ArduinoCore-avr#312) it's different from Xtensa, I've now optimized both PRs for size, thanks for asking the question.

@dok-net dok-net mentioned this pull request Jan 29, 2020
Merged
devyte
devyte requested changes Feb 1, 2020
View reviewed changes
@dok-net dok-net force-pushed the print64bit branch 4 times, most recently from 76acf6c to 127e75f Compare February 5, 2020 13:34
@dok-net dok-net requested a review from devyte March 4, 2020 13:44
devyte
devyte requested changes Apr 18, 2020
View reviewed changes
@devyte
Copy link
Collaborator

devyte commented Apr 18, 2020

@dok-net just the one change and this is good from me.

@dok-net
Copy link
Contributor Author

dok-net commented Apr 18, 2020 via email

@dok-net
Copy link
Contributor Author

dok-net commented Sep 30, 2020

This today got merged in Arduino Core for ESP32 master, espressif/arduino-esp32#3688

@devyte devyte merged commit 96243d7 into esp8266:master Oct 1, 2020
@devyte devyte added this to the 3.0.0 milestone Oct 1, 2020
@dok-net dok-net deleted the print64bit branch October 3, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
component: core type: enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dok-net @devyte @d-a-v