This pull request is now in conflict :(

@kan-bayashi Espnet depends on nnmnkwii(https://github.com/espnet/espnet/blob/master/setup.py#L67), but the requirement of nnmkkwii for numpy is not compatible with python=3.10 (https://github.com/espnet/espnet/actions/runs/4079849732/jobs/7031662783#step:6:200).

nnmkkwii is invoked only in the following script:

The function used here seems a simple text processing and can be implemented easily. I think nnmkkwii is too large dependency for this purpose because it includes even some cython codes.

I think rewriting it to a local function is better. How do you think?

@r9y9 Is it possible to update nnmnkwii?

@kan-bayashi Let me take a look.

@kan-bayashi New release is up https://pypi.org/project/nnmnkwii/0.1.2/

@r9y9 Thank you for blazing fast release! Super cool!

@kamo-naoyuki Could you try the new version?

@r9y9 pyopenjtalk has same problem, could you have a look?

It seems Ryuichi already fixed the issue in v0.3.0 of pyopenjtalk.
I update the version in #4912

pyopenjtalk seems to be fixed. But gensim has a problem in 3.10 :(

Codecov Report

Merging #4627 (a6b9e88) into master (435ea75) will increase coverage by 3.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4627      +/-   ##
==========================================
+ Coverage   73.48%   77.01%   +3.52%     
==========================================
  Files         606      606              
  Lines       53761    53770       +9     
==========================================
+ Hits        39508    41410    +1902     
+ Misses      14253    12360    -1893     

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more