Fix device mismatch error in GPU decoding with PyTorch 1.13#4941
Merged
mergify[bot] merged 2 commits intoespnet:masterfrom Feb 15, 2023
Merged
Fix device mismatch error in GPU decoding with PyTorch 1.13#4941mergify[bot] merged 2 commits intoespnet:masterfrom
mergify[bot] merged 2 commits intoespnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4941 +/- ##
==========================================
- Coverage 76.63% 76.60% -0.03%
==========================================
Files 604 604
Lines 53934 53934
==========================================
- Hits 41330 41314 -16
- Misses 12604 12620 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Thanks, @pyf98! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from PyTorch 1.13, we will encounter an error if a cpu tensor is indexed by a cuda tensor: https://github.com/pytorch/pytorch/releases/tag/v1.13.0
This affects our standard GPU decoding. (Not sure if it affects other decoding algorithms.)