Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CHiME-7 DASR MD5 checksum fix for mixer6/train_call#4942

Merged
simpleoier merged 14 commits intoespnet:masterfrom
popcornell:chime7task1
Feb 17, 2023
Merged

CHiME-7 DASR MD5 checksum fix for mixer6/train_call#4942
simpleoier merged 14 commits intoespnet:masterfrom
popcornell:chime7task1

Conversation

@popcornell
Copy link
Contributor

@popcornell popcornell commented Feb 15, 2023 •
edited
Loading

md5sum JSON fix for train_call @kamo-naoyuki @Emrys365 @YoshikiMas can any of you try if now data checks successfully ?
I've recomputed the hashes with the corrected files.

@mergify mergify bot added the ESPnet2 label Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023 •
edited
Loading

Codecov Report

Merging #4942 (a6672cf) into master (9c7bde4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4942   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files         604      604           
  Lines       53934    53934           
=======================================
  Hits        41334    41334           
  Misses      12600    12600
Flag Coverage Δ
test_integration_espnet1 66.33% <ø> (ø)
test_integration_espnet2 47.42% <ø> (ø)
test_python 66.55% <ø> (ø)
test_utils 23.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot added the README label Feb 15, 2023
@sw005320 sw005320 added Bugfix Recipe ASR Automatic speech recogntion labels Feb 15, 2023
@sw005320 sw005320 added this to the v.202303 milestone Feb 15, 2023
@popcornell popcornell changed the title CHiME-7 DASR CHiME-7 DASR MD5 checksum fix for mixer6/train_call Feb 15, 2023
@kamo-naoyuki
Copy link
Collaborator

kamo-naoyuki commented Feb 16, 2023

FIles under train_call are okay now, but chime6/uem/train/all.uem differs. (I didn't realize it yesterday, sorry )

S03 1 57.550 7883.759
S04 1 49.670 8977.523
S05 1 104.680 9104.918
S06 1 57.370 9007.653
S07 1 53.160 8813.663
S08 1 70.410 9095.833
S12 1 56.730 8964.495
S13 1 72.360 9011.740
S16 1 62.000 9139.665
S17 1 55.280 9137.262
S18 1 72.520 9792.020
S22 1 50.040 9344.893
S23 1 62.920 10724.219
S24 1 61.430 9438.683

@popcornell
Copy link
Contributor Author

popcornell commented Feb 16, 2023

I think this last commits should fix it

@kamo-naoyuki
Copy link
Collaborator

kamo-naoyuki commented Feb 17, 2023

All checks pass now.

@popcornell popcornell mentioned this pull request Feb 17, 2023
Merged
@kamo-naoyuki
Copy link
Collaborator

kamo-naoyuki commented Feb 17, 2023

@popcornell As for the problem about using a test set as validation, I'll handle it by some way at tool level.

@popcornell
Copy link
Contributor Author

popcornell commented Feb 17, 2023

Thank you very much !
Right now this is sufficient BTW. Ping me when it is solved so I will remove the copy part

simpleoier
simpleoier approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@simpleoier simpleoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simpleoier simpleoier merged commit 5e865a6 into espnet:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simpleoier simpleoier simpleoier approved these changes

Assignees

No one assigned

Labels

ASR Automatic speech recogntion Bugfix ESPnet2 README Recipe

Projects

None yet

Milestone

v.202303

Development

Successfully merging this pull request may close these issues.

4 participants

@popcornell @kamo-naoyuki @simpleoier @sw005320