Fix '__floordiv__ is deprecated' warnings #4945
Merged
sw005320 merged 1 commit intoespnet:masterfrom Feb 20, 2023
Merged
Conversation
When you do this:
>>> speech2text = Speech2Text(...)
torch emits a couple of deprecation warnings:
UserWarning: __floordiv__ is deprecated, and its behavior will change
in a future version of pytorch. It currently rounds toward 0 (like the
'trunc' function NOT 'floor'). This results in incorrect rounding for
negative values. To keep the current behavior, use torch.div(a, b,
rounding_mode='trunc')
Fix the issue as suggested by the error message.
Signed-off-by: Fujimoto Seiji <[email protected]>
6efe54a to
919b3e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4945 +/- ##
==========================================
- Coverage 76.63% 74.52% -2.12%
==========================================
Files 604 604
Lines 53934 53912 -22
==========================================
- Hits 41334 40176 -1158
- Misses 12600 13736 +1136
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Thanks, @fujimotos! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we do this with
torch >= 0.12.1:PyTorch emits a couple of deprecation warnings:
Fix the problematic code accordingly, so that users won't see confusing warnings.