Merged
Conversation
ftshijt
reviewed
Mar 2, 2023
Collaborator
ftshijt
left a comment
There was a problem hiding this comment.
LGTM! some minor comments for the part.
egs2/ofuton_p_utagoe_db/svs1/conf/tuning/finetune_joint_rnn_hifigan.yaml
Outdated
Show resolved
Hide resolved
egs2/ofuton_p_utagoe_db/svs1/conf/tuning/finetune_joint_rnn_hifigan.yaml
Outdated
Show resolved
Hide resolved
egs2/ofuton_p_utagoe_db/svs1/conf/tuning/finetune_joint_xiaoice_hifigan.yaml
Outdated
Show resolved
Hide resolved
egs2/ofuton_p_utagoe_db/svs1/conf/tuning/train_joint_rnn_hifigan.yaml
Outdated
Show resolved
Hide resolved
ftshijt
reviewed
Mar 2, 2023
| ) -> Tuple[str, ...]: | ||
| if not inference: | ||
| retval = ("spembs", "durations", "pitch", "energy", "sids", "lids") | ||
| retval = ("spembs", "durations", "pitch", "energy", "sids", "lids", "feats") |
Collaborator
There was a problem hiding this comment.
Probably, we do not need to add additional feats here but reuse the singing variable. We can have more discussion after the deadline for interspeech.
…e_hifigan.yaml Co-authored-by: Jiatong <[email protected]>
…figan.yaml Co-authored-by: Jiatong <[email protected]>
…an.yaml Co-authored-by: Jiatong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4977 +/- ##
==========================================
- Coverage 77.10% 76.96% -0.15%
==========================================
Files 604 606 +2
Lines 53613 53751 +138
==========================================
+ Hits 41338 41368 +30
- Misses 12275 12383 +108
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
LGTM! Let's work on the CI after the interspeech. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ftshijt, here are updates on Muskits.