Modify format_wav_scp.py to support PCM of uint8, int32, float32, float64, etc.#4997
Merged
kamo-naoyuki merged 1 commit intoespnet:masterfrom Mar 13, 2023
Merged
Modify format_wav_scp.py to support PCM of uint8, int32, float32, float64, etc.#4997kamo-naoyuki merged 1 commit intoespnet:masterfrom
kamo-naoyuki merged 1 commit intoespnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4997 +/- ##
==========================================
+ Coverage 76.91% 77.00% +0.09%
==========================================
Files 606 606
Lines 53770 53748 -22
==========================================
+ Hits 41355 41388 +33
+ Misses 12415 12360 -55
Flags with carried forward coverage won't be shown. Click here to find out more. see 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
|
I'll merge this PR if there are no comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue of the current script
np.int16is specified for the soundfile.read:soundfile.read(-. dtype=np.int16). This indicates some problems if the PCM data has uint8 or float type.The modification of PR
soundfile.read()withtou specifying the dtype. Note thatsoundfile.read()always returns float64 array in spite of the dtype of input pcm, andsoundfile.writewrite a float64 array in int16 pcm.e.g. The following
wav.scpwithsegmentsalso works.